[Freeipa-devel] [PATCH 0070] Normalization check only for IDNA domains

[Alexander Bokovoy]

On Fri, 27 Jun 2014, Jan Cholasta wrote:
>On 27.6.2014 10:15, Alexander Bokovoy wrote:
>>On Fri, 20 Jun 2014, Martin Basti wrote:
>>>On Fri, 2014-06-20 at 10:32 +0200, Jan Cholasta wrote:
>>>>On 18.6.2014 16:49, Martin Basti wrote:
>>>>> Due to compability with older versions, only IDNA domains should be
>>>>> checked
>>>>> Patch attached.
>>>>
>>>>I'm not particularly happy about the u'\xdf' special case. Isn't there a
>>>>better way to do this check?
>>>I cant find better way. u'\xdf' is mapped to ss, and ss is not IDN
>>>string.
>>>
>>>Or just remove this validation.
>>>
>>>>(BTW I really think this should be a warning, not an error, but that
>>>>would require larger amount of work, so I guess it's OK for now.)
>>>(More pain than gain)
>>Main thing in this patch is that the check should not be done against
>>non-IDN strings. I want this version of the patch to go in for that
>>reason as currently you cannot even complete ipa-adtrust-install run due
>>to IDN normalisation check being applied to non-IDN domains.
>
>On non-IDN domains, the only effect of IDN normalization is that it 
>lower-cases the names (right?), so the check should compare 
>lower-cased original name with the normalized name, instead of 
>special-casing certain characters etc.
.. what's the reason to do such comparison then? lower-cased non-IDN
name will be equal to lower-cased normalized non-IDN name by definition,
so the check is not needed in this case, at all.

Otherwise, we get
 [15/21]: adding special DNS service records
Unexpected error - see /var/log/ipaserver-install.log for details:
ConversionError: invalid 'name': domain name
'_ldap._tcp.Default-First-Site-Name._sites.dc._msdcs' and normalized
domain name '_ldap._tcp.default-first-site-name._sites.dc._msdcs' do not
match. Please use only normalized domains

-- 
/ Alexander Bokovoy