[Freeipa-devel] [PATCHES 0066-0067] Upgrade procedure for forwardzones

[Martin Basti]

> 1) This is not how you compare bool singletons in Python:
> 
> +        if state == False:
> +            # no upgrade is needed
> +            return (False, False, [])
> 
> Rather use "state is False"
> 
> Besides that, the upgrade worked fine for me (after I applied my patch 471. So
> if you change that one issue, I am willing to ack.
> 
> Martin

Updated patch attached

-- 
Martin^2 Basti
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0067-3-Upgrade-special-master-zones-to-forward-zones.patch
Type: text/x-patch
Size: 9237 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140627/fd208831/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0066-2-Added-upgrade-step-executed-before-schmema-is-upgrad.patch
Type: text/x-patch
Size: 6622 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140627/fd208831/attachment-0001.bin>