[Freeipa-devel] [PATCH] 680-682 webui: validation reporting improvements

[Fraser Tweedale]

On Fri, Jun 27, 2014 at 10:54:39AM +0200, Petr Vobornik wrote:
> On 27.6.2014 09:48, Fraser Tweedale wrote:
> >On Wed, Jun 25, 2014 at 06:58:52PM +0200, Petr Vobornik wrote:
> >>Patch 618 fixes a bug.
> >>
> >>Patches 680 and 681 were implemented along with it. They address pspacek's
> >>usability rant :).
> >>
> >>[PATCH] 680 webui: show notification instead of modal dialog on validation
> >>error
> >>[PATCH] 681 webui: fix required error notification in multivalued widget
> >>[PATCH] 682 webui: focus invalid widget on validation error
> >>--
> >>Petr Vobornik
> >
> >ACK on 680 and 682.
> >
> >On 681: diff makes sense; I'm not 100% sure my testing has covered
> >cases that were previously failing.  ACK if you're confident,
> >otherwise could you provide steps to verify?
> 
> You need to find a required multivalued field. One is in "Identity/Realm
> Domains". Delete all values and hit update. It's little bit related to
> ticket: https://fedorahosted.org/freeipa/ticket/4057
> 
> Also when verifying validators in multivalued field, it's good to check if
> errors are provided only for "invalid" values, etc..  good test field is in
> "DNS/DNS Zones/some zone/Settings/ there is "Allow query" field which
> accepts network address, "any" or "none".
> 

I can't discern any difference in behaviour of the multi-value
fields from before and after your patch.  I tried with the
"Identity/Realm Domains" as suggested.

Maybe I missed something.  Has someone else been able to verify?

Fraser

> >
> >Cheers,
> >
> >Fraser
> >
> -- 
> Petr Vobornik