[Freeipa-devel] [PATCH 0078-0079] DNSSEC: Add TLSA record

[Petr Vobornik]

On 27.6.2014 14:55, Martin Basti wrote:
> On Thu, 2014-06-26 at 13:57 +0200, Petr Vobornik wrote:
>> On 25.6.2014 14:35, Martin Basti wrote:
>>> On Wed, 2014-06-25 at 14:31 +0200, Martin Basti wrote:
>>>> Ticket https://fedorahosted.org/freeipa/ticket/4328#comment:12
>>>> Patches attached.
>>>>
>>>> Note: ACI will be updated in another patch which fix ACIs in DNS plugin
>>>
>>> Patches are here
>>>
>> What are patch 0078's dependencies? I'm missing necessary blobs..
>> (current master). Also it requires rebase because of today's pushes to
>> master (VERSION conflict).
>
> Rebased patch attached
>

Patch 0078-2:

Just nitpicks.

1. The LDAP attribute type description should be changed to something 
more meaningful. the "DNS-Based Authentication of Named Entities - 
Transport Layer Security Protocol, RFC 6698" is the complete effort. It 
does not say anything about the TLSA record itself. I suggest: "TLSA 
certificate association, RFC 6698" which is used in chapter 2 of RFC 6698.

2. Nitpick: Not a proper alphabetic order ;)
-    u'TSIG', u'TXT',
+    u'TSIG', u'TLSA', u'TXT',


Patch 0079:

3. A js-lint warning:

/dns.js(1140): lint warning: extra comma is not recommended in array 
initializers
             ]
............^

Just remove the comma on line 1139. To check it, run:

    `jsl -nofilelisting -nologo -nosummary -conf jsl.conf`

in install/ui directory
-- 
Petr Vobornik