[Freeipa-devel] [PATCHES] 0337-0343 YAML test configuration

[Petr Viktorin]

On 03/03/2014 01:41 PM, Tomas Babej wrote:
> Finally got to this patchset!
>
> PATCH 337: ACK
> PATCH 338: ACK
>
> This prohibits us to use extra roles that end in digits. Can you put a
> note explaining that in
>
> http://www.freeipa.org/page/V3/Integration_testing#Host_configuration

Updated.

> Also, this wiki page points out to environment variables so that it
> seems it is the preferred method of configuration. We should mention
> more user friendly YAML here first.

Let's do that when the patches are pushed. #3938 should stay open until 
it's done.

> PATCH 339: ACK
> PATCH 340: ACK
> PATCH 341:
>
> The have_master variable seems redundant in from_dict method (it's only
> a local definition and not referenced anywhere else):
>
> +    def from_dict(cls, dct, config):
> +        from ipatests.test_integration.host import BaseHost
> +
> +        domain_type = dct.pop('type')
> +        assert domain_type in ('IPA', 'AD')
> +        domain_name = dct.pop('name')
> +        self = cls(config, domain_name, domain_type)
> +
> +        have_master = False
> +        for host_dict in dct.pop('hosts'):
> +            host = BaseHost.from_dict(host_dict, self)
> +            self.hosts.append(host)
> +            if host.role == 'master':
> +                have_master = True
> +
> +        check_config_dict_empty(dct, 'domain %s' % domain_name)
> +
> +        return self

Right you are. Fixed.

> PATCH 342: ACK
> PATCH 343: ACK
>
> PATCH 348: ACK
> PATCH 349: ACK
>
>

-- 
Petr³
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0337.3-test_integration.config-Fix-crash-in-to_env-when-no-.patch
Type: text/x-patch
Size: 2357 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0338.3-test_integration.config-Do-not-save-the-input-enviro.patch
Type: text/x-patch
Size: 5588 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0339.3-test_integration.config-Use-a-more-declarative-appro.patch
Type: text/x-patch
Size: 7368 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0340.3-test_integration.config-Do-not-store-the-index-in-Do.patch
Type: text/x-patch
Size: 8601 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0341.3-test_integration.config-Load-store-from-to-dicts.patch
Type: text/x-patch
Size: 6198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0342.3-test_integration.config-Add-environment-variables-fo.patch
Type: text/x-patch
Size: 1953 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0343.3-ipa-test-config-Add-json-and-yaml-output-options.patch
Type: text/x-patch
Size: 3905 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0348.3-test_integration.config-Convert-some-text-values-to-.patch
Type: text/x-patch
Size: 3098 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0349.3-Add-tests-for-integration-test-configuration.patch
Type: text/x-patch
Size: 17460 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140304/8cae56d3/attachment-0008.bin>