[Freeipa-devel] [PATCH] 531-541 OTP UI

[Misnyovszki Adam]

On Wed, 12 Mar 2014 15:41:31 +0100
Petr Vobornik <pvoborni at redhat.com> wrote:

> On 7.3.2014 18:10, Petr Vobornik wrote:
> > Attaching new version of 537 which adds combobox control for owner
> > attribute instead of textbox.
> >
> > All other patches are attached as well to reduce confusion in case
> > of ACK :).
> >
> >
> 
> The entire patchset was rebased.


Review log:
- add otp token: OK
- delete otp token: OK
- bulk delete: OK
- edit otp token: OK
- single disable token: OK
- single enable token: OK
- bulk enable token: OK
- bulk disable token: OK
- configuration url working: OK
- after bulk operation, checkboxes for items unchecked, which is good,
  but the bulk check checkbox remains checked, propose: either all
  checkboxes should remain checked, or all of them unchecked -
  https://fedorahosted.org/freeipa/ticket/4245
- validity fields accept non existing timeframe(ie start: 2013-01-01
  00:00:00Z, end: 2012-01-01 00:00:00Z) -
  https://fedorahosted.org/freeipa/ticket/4244
- after edit, screen doesn't go back to list, any other action errors
  with a "[UUID]: OTP token not found" because of uniqueid change -
  https://fedorahosted.org/freeipa/ticket/4227 

all the opened tickets are not the scope of this patch, so
ACK

greets
Adam