[Freeipa-devel] [DOC] 0006 Chapter 5 update

[Petr Viktorin]

On 09/26/2013 06:52 PM, Martin Basti wrote:
> Patch for chapter 5
>
> Contains patch for ticket
> https://fedorahosted.org/freeipa/ticket/3842

Hello,
Thanks for the patches!

Next time, when you do multiple changes, please split them into multiple 
patches. Each of the bullet points in the commit message could have been 
a separate patch.
However splitting the patch now is probably not worth the effort.

I did however split the whitespace fixes to make my job easier. I also 
rebased a minor conflict. Attaching the patches for convenience.

In section 5.1.3 the examples are missing the [user at ipaserver ~] prompt.
In section 5.2.2.2 there's an extra `$` prompt that's not present in 
other syntax examples.

Section 5.2.4.1. should not be an ordered list since it presents two 
ways to do the same thing.

In Table 5.3, instead of removing posixgroup altogether you should 
mention that it's only added for POSIX groups.

Otherwise the changes look good.

-- 
Petr³

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-docs-pviktori-0001-Chapter-5-Users-Remove-trailing-whitespace.patch
Type: text/x-patch
Size: 47849 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140318/31c5b6ce/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0006+pviktori-Chapter-5-fixed-images-examples-added-new-TIPs.patch
Type: text/x-patch
Size: 1922066 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140318/31c5b6ce/attachment-0001.bin>