[Freeipa-devel] [PATCH] 560 webui: rename domNode to dom_node

Misnyovszki Adam amisnyov at redhat.com
Thu Mar 20 15:51:33 UTC 2014


On Wed, 19 Mar 2014 16:02:12 +0100
Petr Vobornik <pvoborni at redhat.com> wrote:

> - unites domNode and dom_node usage to dom_node

Nack,

install/ui/test/details_tests.js:236                                            
install/ui/test/details_tests.js:242                                            
                                                                                
only finds element, because context(ie domNode) is undefined, so it
falls back to html, not the best idea 

install/ui/src/freeipa/widgets/App.js:55                                        
                                                                                
not sure if this causes errors, but it's worth renaming for consistency 

Greets,
Adam




More information about the Freeipa-devel mailing list