[Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

[Misnyovszki Adam]

On Fri, 21 Feb 2014 16:06:27 +0100
Petr Vobornik <pvoborni at redhat.com> wrote:

> On 21.2.2014 15:45, Adam Misnyovszki wrote:
> > Hi,
> > According to http://tools.ietf.org/html/rfc2798 ipa client and web
> > ui extended with employeenumber field.
> >
> > https://fedorahosted.org/freeipa/ticket/4165
> >
> > Question is, that should we extend user with other fields which are
> > in the RFC, (carLicense, departmentNumber, employeeType, etc) if we
> > already touched this code?
> >
> > Thanks
> > Adam
> >
> 
> 
> +        Int('employeenumber?',
> +            label=_('Employee ID'),
> +            minvalue=1,
> +        ),
> 
> 
> Why Int and different label? IMO it should be Str and 'Employee
> Number'
> 
> 2.4. Employee Number
> 
>     Numeric or alphanumeric identifier assigned to a person, typically
>     based on order of hire or association with an organization.
> Single valued.
> 
>      ( 2.16.840.1.113730.3.1.3
>        NAME 'employeeNumber'
>        DESC 'numerically identifies an employee within an
> organization' EQUALITY caseIgnoreMatch
>        SUBSTR caseIgnoreSubstringsMatch
>        SYNTAX 1.3.6.1.4.1.1466.115.121.1.15
>        SINGLE-VALUE )
> 
Hi,
fixed, also some other fields added. Note, that according to the rfc,
licence plate field should be multivalue, should I cange that(it is an
existing field). Also, should I write test cases(especially for
preferredlanguage)?
Greets
Adam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-amisnyov-0005-2-Extending-user-plugin-with-inetOrgPerson-fields.patch
Type: text/x-patch
Size: 9993 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20140321/6ce7e571/attachment.bin>