[Freeipa-devel] [PATCH] 560 webui: rename domNode to dom_node

[Misnyovszki Adam]

On Tue, 25 Mar 2014 12:49:24 +0100
Petr Vobornik <pvoborni at redhat.com> wrote:

> On 20.3.2014 16:51, Misnyovszki Adam wrote:
> > On Wed, 19 Mar 2014 16:02:12 +0100
> > Petr Vobornik <pvoborni at redhat.com> wrote:
> >
> >> - unites domNode and dom_node usage to dom_node
> >
> > Nack,
> >
> > install/ui/test/details_tests.js:236
> > install/ui/test/details_tests.js:242
> >
> > only finds element, because context(ie domNode) is undefined, so it
> > falls back to html, not the best idea
> >
> > install/ui/src/freeipa/widgets/App.js:55
> >
> > not sure if this causes errors, but it's worth renaming for
> > consistency
> >
> > Greets,
> > Adam
> >
> 
> all fixed, patch attached.

ACK