[Freeipa-devel] [PATCH] 561 webui: make navigation module independent on app module

Misnyovszki Adam amisnyov at redhat.com
Wed Mar 26 14:36:13 UTC 2014


On Wed, 19 Mar 2014 16:02:19 +0100
Petr Vobornik <pvoborni at redhat.com> wrote:

> When some module used 'freeipa/navigation' it pulled the entire Web UI
> because navigation depended on app.
> 
> This patch splits the app into two modules: app and app_container.
> App specifies the entities which are part of final application.
> app_container module represents the application boot classes.
> Navigation now depends on app_container.

Hi,
tests ran as expected, and it works, so
ACK.
Note:
there are two typos in copyright, app.js:5(./),
app_container.js:1(space before comment), should be corrected before
push.
Thanks
Adam




More information about the Freeipa-devel mailing list