[Freeipa-devel] [PATCHES] 366-372 Additional Coverity fixes

[Alexander Bokovoy]

On Tue, 11 Nov 2014, Jan Cholasta wrote:
>>From 7ca2b25b93f1e3bff1e4c54ef1794cad462e533a Mon Sep 17 00:00:00 2001
>From: Jan Cholasta <jcholast at redhat.com>
>Date: Mon, 10 Nov 2014 17:40:35 +0000
>Subject: [PATCH 3/7] Fix Kerberos error handling in ipa-sam
>
>https://fedorahosted.org/freeipa/ticket/4713
>---
> daemons/ipa-sam/ipa_sam.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/daemons/ipa-sam/ipa_sam.c b/daemons/ipa-sam/ipa_sam.c
>index 3b69f9e..e711299 100644
>--- a/daemons/ipa-sam/ipa_sam.c
>+++ b/daemons/ipa-sam/ipa_sam.c
>@@ -4233,7 +4233,7 @@ static int bind_callback(LDAP *ldap_struct, struct smbldap_state *ldap_state, vo
> 	krb5_free_principal(data.context, in_creds.server);
> 	krb5_free_principal(data.context, in_creds.client);
> 
>-	if (rc) {
>+	if (rc != 0 && rc != KRB5KRB_AP_ERR_TKT_NYV && rc != KRB5KRB_AP_ERR_TKT_EXPIRED) {
> 		rc = bind_callback_obtain_creds(&data);
> 		if (rc) {
> 			bind_callback_cleanup(&data, rc);
ACK
-- 
/ Alexander Bokovoy