[Freeipa-devel] [PATCHES] 366-372 Additional Coverity fixes

Alexander Bokovoy abokovoy at redhat.com
Mon Nov 24 13:42:55 UTC 2014


On Mon, 10 Nov 2014, Jan Cholasta wrote:
>From 4e4600da5cd9c42b76a56cdbdb4c1314ee7b0a2a Mon Sep 17 00:00:00 2001
>From: Jan Cholasta <jcholast at redhat.com>
>Date: Mon, 10 Nov 2014 18:12:52 +0000
>Subject: [PATCH 7/7] Fix unchecked return value in krb5 common utils
>
>https://fedorahosted.org/freeipa/ticket/4651
>---
> util/ipa_krb5.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/util/ipa_krb5.c b/util/ipa_krb5.c
>index 6334ed3..feb23ea 100644
>--- a/util/ipa_krb5.c
>+++ b/util/ipa_krb5.c
>@@ -730,6 +730,10 @@ struct berval *create_key_control(struct keys_container *keys,
> 
>         if (ksdata[i].salttype == NO_SALT) {
>             ret = ber_printf(be, "}");
>+            if (ret == -1) {
>+                ber_free(be, 1);
>+                return NULL;
>+            }
>             continue;
>         }
> 
ACK

-- 
/ Alexander Bokovoy




More information about the Freeipa-devel mailing list