[Freeipa-devel] [PATCH] 0021 Fix example usage in ipa man page.

[David Kupka]

On 10/08/2014 08:19 AM, David Kupka wrote:
> On 10/08/2014 08:02 AM, Alexander Bokovoy wrote:
>> On Wed, 08 Oct 2014, David Kupka wrote:
>>> https://fedorahosted.org/freeipa/ticket/4587
>>> --
>>> David Kupka
>>
>>> From 883e90237fbde1075d00990568cde18773e80611 Mon Sep 17 00:00:00 2001
>>> From: David Kupka <dkupka at redhat.com>
>>> Date: Wed, 8 Oct 2014 01:43:47 -0400
>>> Subject: [PATCH] Fix example usage in ipa man page.
>>>
>>> https://fedorahosted.org/freeipa/ticket/4587
>>> ---
>>> ipa.1 | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/ipa.1 b/ipa.1
>>> index
>>> fc39fceaae5aa4c614ccaaa7e608f2326d926755..6acfcfd9f7ab580c9b086fa249903cdf10544cdb
>>>
>>> 100644
>>> --- a/ipa.1
>>> +++ b/ipa.1
>>> @@ -149,7 +149,7 @@ Create a new user with username "foo", first name
>>> "foo" and last name "bar".
>>> \fBipa group\-add bar \-\-desc "this is an example group"
>>> Create a new group with name "bar" and description "this is an example
>>> group".
>>> .TP
>>> -\fBipa group\-add\-member bar \-\-users=admin,foo\fR
>>> +\fBipa group\-add\-member bar \-\-users={admin,foo}\fR
>>> Add users "admin" and "foo" to the group "bar".
>>> .TP
>>> \fBipa user\-show foo \-\-raw\fR
>> I would like to see a stance about shell expansion use here. May be add
>> a phrase about that right after "Add users ... to the group ..."? It
>> might not be entirely obvious to other people that we rely on a shell
>> expansion features here.
>>
>
> At first, I wanted to remove one of users mentioned there but
> '--users=foo' looks confusing to me (using plural and specifying just
> one value).
> Personally I would prefer to change all plural parameters to singular
> form but it is a large change considering the benefit.
> What about two examples? One '--users=foo' and other using shell expansion.
>
>

I forget to update the patch, sorry.

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0021-3-Fix-example-usage-in-ipa-man-page.patch
Type: text/x-patch
Size: 1157 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141008/7b140bc8/attachment.bin>