[Freeipa-devel] [PATCH] 131-132 extdom: add support for sss_nss_getorigbyname()

[Jakub Hrozek]

On Mon, Oct 20, 2014 at 10:43:07AM +0200, Sumit Bose wrote:
> On Sun, Oct 19, 2014 at 10:04:29PM +0200, Jakub Hrozek wrote:
> > On Fri, Oct 17, 2014 at 11:53:44AM +0200, Sumit Bose wrote:
> > > Hi,
> > > 
> > > the first patch replaces sss_nss_getsidbyname() by
> > > sss_nss_getorigbyname() for the new version of the extdom interface.
> > > The new call returns more data about the original object and allows the
> > > IPA client to have the same information about the object in the SSSD
> > > cache as the IPA servers.
> > > 
> > > The second patch just removes an obsolete dependency.
> > > 
> > > bye,
> > > Sumit
> > 
> > Hi,
> > 
> > I was unable to send the patches through Coverity, the RH server seems
> > to be having issues. I'll wait until tomorrow, if the problems persist,
> > we'll just skip Coverity and fix any potential problems post-push.
> > 
> > > From 928c04c35601b7bc1c57c1320e4a746abc35e947 Mon Sep 17 00:00:00 2001
> > > From: Sumit Bose <sbose at redhat.com>
> > > Date: Fri, 10 Oct 2014 10:56:37 +0200
> > > Subject: [PATCH 131/132] extdom: add support for sss_nss_getorigbyname()
> > 
> > [...]
> > 
> > > @@ -576,13 +613,14 @@ static int handle_gid_request(enum request_types request_type, gid_t gid,
> > >      enum sss_id_type id_type;
> > >      size_t buf_len;
> > >      char *buf = NULL;
> > > +    struct sss_nss_kv *kv_list;
> > 
> > Please set kv_list to NULL here, you're freeing the pointer
> > unconditionally in the done handler, but in some cases (request_type ==
> > REQ_SIMPLE) kv_list is not set at all.
> 
> Thank you for the review. I fixed it here and at the two other places.

Thanks.

> Since sss_nss_getorigbyname() will only be available in the upcoming
> SSSD release I added 'BuildRequires:  libsss_nss_idmap-devel >= 1.12.2'
> to freeipa.spec.in.

oops, nice catch, that's what I get for building from source..

> 
> New version attached.

ACK! I found an unrelated SSSD bug, but this patch is fine.