[Freeipa-devel] [PATCHES 0117, 0135-0149] DNSSEC support

[Jan Cholasta]

Hi,

Dne 20.10.2014 v 17:37 Petr Spacek napsal(a):
> On 20.10.2014 17:21, Martin Basti wrote:
>> Hello! Hold your hats, DNSSEC patches are here.
>>
>> Martin^2, Petr^2
>
> For testing you will need following package:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=7915293
>
>  From me, functional self-ACK :-)
>

Patch 117:

1)

As we discussed off-line, this code is wrong and a ticket should be 
opened to fix it to properly handle service files conflicting with the 
mask command:

+        if instance_name != "":
+            srv_tgt = os.path.join(paths.ETC_SYSTEMD_SYSTEM_DIR, 
instance_name)
+            # remove instance file or link before masking
+            if os.path.islink(srv_tgt):
+                os.unlink(srv_tgt)


Patch 137:

1)

There are some whitespace errors:

Applying: DNSSEC: add ipapk11helper module
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:95: trailing 
whitespace.
  *
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:100: trailing 
whitespace.
  *
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:105: trailing 
whitespace.
  *
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:203: trailing 
whitespace.
  *
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:208: trailing 
whitespace.
  *
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.


Patch 138:

1)

There is a whitespace error:

Applying: DNSSEC: DNS key synchronization daemon
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:54: new blank 
line at EOF.
+
warning: 1 line adds whitespace errors.


Patch 140:

1)

Unless there is a dnssec_keys ipalib plugins, I don't think there should 
be container_dnssec_keys. Use "DN(('cn', 'keys'), ('cn', 'sec'), 
api.env.container_dns, ...)" instead of 
"DN(api.env.container_dnssec_keys, ...)".


2)

The masking method definitions in PlatformService should be moved to 
patch 117.


3)

The changes in dnskeysyncinstance.py, odsexportedinstance.py and 
opendnssecinstance.py should be moved to patches 138 and 139.


Patch 147:

1)

There are some whitespace errors:

Applying: DNSSEC: add ipa dnssec daemons
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:135: trailing 
whitespace.
     # synchronize metadata about master keys in LDAP
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:1228: 
trailing whitespace.

/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:1291: 
trailing whitespace.

/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:873: new 
blank line at EOF.
+
/home/jcholast/FreeIPA/git/freeipa/.git/rebase-apply/patch:1126: new 
blank line at EOF.
+
warning: squelched 1 whitespace error
warning: 6 lines add whitespace errors.


Honza

-- 
Jan Cholasta