[Freeipa-devel] [PATCH] 0025 Respect UID and GID soft static allocation.

[David Kupka]

On 10/24/2014 01:06 PM, David Kupka wrote:
> On 10/24/2014 10:43 AM, Martin Basti wrote:
>> On 24/10/14 09:51, David Kupka wrote:
>>> https://fedorahosted.org/freeipa/ticket/4585
>> NACK
>>
>> 1)
>> Why is there line with 'DS System User?' The comment should depend on
>> service.
>>
>> +            args = [
>> +                paths.USERADD,
>> +                '-g', group,
>> +                '-c', 'DS System User',
>> +                '-d', homedir,
>> +                '-s', shell,
>> +                '-M', '-r', name,
>> +            ]
>
> This was part of the original code and I didn't notice it. Nice catch,
> thanks.
>
>>
>> 2)
>> code create_system_user is duplicated between base and redhat tasks with
>> platform dependent changes.
>> IMO it would be better to have one method to create user, with keyword
>> arguments.  And then platform dependent method which will call method to
>> create user with appropriate arguments (or with default arguments)
>>
>
> You're right it was ugly.
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
>
I shouldn't break SOLID principles.

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0025-3-Respect-UID-and-GID-soft-static-allocation.patch
Type: text/x-patch
Size: 7100 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20141024/136c6364/attachment.bin>