[Freeipa-devel] [PATCHES] 0688-0689 Remove Editable DN and DN component classes
Petr Viktorin
pviktori at redhat.com
Fri Apr 10 13:58:53 UTC 2015
The attached patches remove EditableDN, EditableRDN and EditableAVA.
They depend on Petr Voborník's patch 811 (performance: faster DN
implementation).
Mutable DNs are not very useful. When creating them it is easier to work
with lists or generators, and needing to change DNs aside from
operations like `DN(new_rdn, original[1:])` is very rare -- I'd even say
theoretical.
Mutable DNs are not hashable, so they can't be used as dist keys.
Storing them as "keys" in other structures (e.g. in a LDAPEntry) is
dangerous -- it's hard to reason about outside modifications.
The first patch removes the last use of EditableDN. I could be convinced
it's not an improvement in elegance/readability, but I believe this is
the strongest case for EditableDN in IPA, and it doesn't justify keeping it.
--
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0688-rename_managed-Remove-use-of-EditableDN.patch
Type: text/x-patch
Size: 4671 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150410/2a768e5f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0689-Remove-Editable-DN-and-DN-component-classes.patch
Type: text/x-patch
Size: 135634 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150410/2a768e5f/attachment-0001.bin>
More information about the Freeipa-devel
mailing list