[Freeipa-devel] [PATCH 408-423] ldap: Remove IPASimpleLDAPObject

Mon Apr 13 06:12:18 UTC 2015

Dne 9.4.2015 v 17:28 Petr Viktorin napsal(a):
> On 04/08/2015 03:18 PM, Jan Cholasta wrote:
>> Hi,
>>
>> the attached patches remove IPASimpleLDAPObject from ipaldap.
>>
>> As a result, the one and only IPA LDAP API is the LDAPClient API.
>
> This is definitely an improvement :)
>
> 0408: ACK  (woohoo!)
> 0409: ACK
> 0410:
> I quite like the new __init__ signature, and the context manager
> functionality.
> Can you add a comment for the `object.__setattr__(self, '_conn', None)`
> in _disconnect? It's a real eyesore.

Added.

> 0411: ACK
> 0412: Can _force_schema_updates be set already in __init__?

Unfortunately not. ldap2 is now used with different API instances, and 
the current API instance is not available in __init__.

I'm working on an additional patch for 
<https://fedorahosted.org/freeipa/ticket/3090> to pass the API object to 
plugins in their __init__ (because why do it somewhere else), which will 
fix this.

> 0413: ACK
> 0414: ACK
> 0415: ACK
> 0416: I think you should show off the `with` statement support here.

Fixed.

> 0417: ... and here

Fixed.

> 0418: ACK
> 0419: ACK
> 0420: ACK
> 0421: ACK

Added a comment about ldap2's locking here as well.

Also moved LDAPClient.schema back to its original location to save some 
lines in the patch.

> 0422: ACK, and good riddance

You missed 423 :-)

Thanks for the review.

Updated patches attached.

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-408.1-ldap-Drop-python-ldap-tuple-compatibility.patch
Type: text/x-patch
Size: 4580 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-409.1-ldap-Remove-unused-IPAdmin-methods.patch
Type: text/x-patch
Size: 976 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-410.1-ldap-Add-connection-management-to-LDAPClient.patch
Type: text/x-patch
Size: 5054 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-411.1-ldap-Use-LDAPClient-connection-management-in-IPAdmin.patch
Type: text/x-patch
Size: 1604 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-412.1-ldap-Use-LDAPClient-connection-management-in-ldap2.patch
Type: text/x-patch
Size: 1731 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-413.1-ldap-Add-bind-and-unbind-methods-to-LDAPClient.patch
Type: text/x-patch
Size: 2028 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-414.1-ldap-Use-LDAPClient-bind-and-unbind-methods-in-IPAdm.patch
Type: text/x-patch
Size: 2904 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-415.1-ldap-Use-LDAPClient-bind-and-unbind-methods-in-ldap2.patch
Type: text/x-patch
Size: 4192 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-416.1-ldap-Use-LDAPClient-instead-of-IPASimpleLDAPObject-i.patch
Type: text/x-patch
Size: 1372 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-417.1-cainstance-Use-LDAPClient-instead-of-IPASimpleLDAPOb.patch
Type: text/x-patch
Size: 1688 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-418.1-makeaci-Use-LDAPClient-instead-of-IPASimpleLDAPObjec.patch
Type: text/x-patch
Size: 1440 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-419.1-ldap-Move-value-encoding-from-IPASimpleLDAPObject-to.patch
Type: text/x-patch
Size: 18200 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0011.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-420.1-ldap-Use-LDAPClient-instead-of-IPASimpleLDAPObject-i.patch
Type: text/x-patch
Size: 3149 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-421.1-ldap-Move-schema-handling-from-IPASimpleLDAPObject-t.patch
Type: text/x-patch
Size: 30711 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-422.1-ldap-Use-SimpleLDAPObject-instead-of-IPASimpleLDAPOb.patch
Type: text/x-patch
Size: 1261 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0014.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-423.1-ldap-Remove-IPASimpleLDAPObject.patch
Type: text/x-patch
Size: 5122 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150413/489aa2a0/attachment-0015.bin>