[Freeipa-devel] [PATCHES] 0688-0689 Remove Editable DN and DN component classes

[Petr Viktorin]

On 04/16/2015 09:04 AM, Jan Cholasta wrote:
> Hi,
>
> Dne 10.4.2015 v 15:58 Petr Viktorin napsal(a):
>> The attached patches remove EditableDN, EditableRDN and EditableAVA.
>> They depend on Petr Voborník's patch 811 (performance: faster DN
>> implementation).
>>
>>
>> Mutable DNs are not very useful. When creating them it is easier to work
>> with lists or generators, and needing to change DNs aside from
>> operations like `DN(new_rdn, original[1:])` is very rare -- I'd even say
>> theoretical.
>> Mutable DNs are not hashable, so they can't be used as dist keys.
>> Storing them as "keys" in other structures (e.g. in a LDAPEntry) is
>> dangerous -- it's hard to reason about outside modifications.
>>
>> The first patch removes the last use of EditableDN. I could be convinced
>> it's not an improvement in elegance/readability, but I believe this is
>> the strongest case for EditableDN in IPA, and it doesn't justify keeping
>> it.
>
> LGTM, but patch 688 needs to be rebased.

Here you go.


-- 
Petr Viktorin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0688.2-rename_managed-Remove-use-of-EditableDN.patch
Type: text/x-patch
Size: 4627 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150416/f1129825/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-pviktori-0689.2-Remove-Editable-DN-and-DN-component-classes.patch
Type: text/x-patch
Size: 135634 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150416/f1129825/attachment-0001.bin>