[Freeipa-devel] [PATCHES 0224-0225] Use NTP servers detected from SRV records in ntp configuration

[Martin Basti]

On 16/04/15 13:53, Martin Babinsky wrote:
> On 04/16/2015 01:34 PM, Martin Babinsky wrote:
>> On 04/15/2015 04:17 PM, Martin Basti wrote:
>>> https://fedorahosted.org/freeipa/ticket/4981
>>>
>>> These patches keep usage of IPA server address as NTP server in NTP
>>> configuration on clients, in case that  no NTP servers were 
>>> specified by
>>> user, and no NTP servers were resolved from SRV records. This will
>>> ensure backward compatibility, as IPA does not configure NTP SRV 
>>> records
>>> for each domain automatically.
>>>
>>> Patches attached.
>>>
>>> Martin^2
>>>
>>>
>> PATCH 224 NACK
>> PATCH 225 ACK
>>
>> Patch 224 you keep the original destination (dest="ntp_server")
>> for --ntp-server option, but in patch 226 the code attempts to get the
>> server names from options.ntpservers resulting in:
>>
>> Traceback (most recent call last):
>>    File "/sbin/ipa-client-install", line 2932, in <module>
>>      sys.exit(main())
>>    File "/sbin/ipa-client-install", line 2913, in main
>>      rval = install(options, env, fstore, statestore)
>>    File "/sbin/ipa-client-install", line 2342, in install
>>      if options.ntp_servers:
>> AttributeError: Values instance has no attribute 'ntp_servers'
>>
>> So please fix this.
>>
>> Naming the destination 'ntp_servers' (plural form) seems best because we
>> now store multiple values.
>>
> Also, if renaming "option.ntp_server" to "option.ntp_servers", do not 
> forget to change also these lines in "ipa-client-install":
>
> 2852         if options.ntp_server:
> 2853             ntp_servers = options.ntp_server
>
> (line numbers after applying patches 224-226)
>
Stupid me, thank you

Updated patches attached.

-- 
Martin Basti

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0224.2-ipa-client-make-ntp-server-option-multivalued.patch
Type: text/x-patch
Size: 5198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150416/cdd6fffb/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbasti-0225.2-ipa-client-use-NTP-servers-detected-from-SRV.patch
Type: text/x-patch
Size: 1875 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150416/cdd6fffb/attachment-0001.bin>