[Freeipa-devel] [PATCH 0046] Remove unneeded --ip-address option in ipa-adtrust-install

[Gabe Alford]

On Tue, Apr 28, 2015 at 7:18 AM, Martin Basti <mbasti at redhat.com> wrote:

>  On 27/04/15 15:02, Gabe Alford wrote:
>
>  Hello,
>
> Fix for https://fedorahosted.org/freeipa/ticket/4575
>
>  Thanks,
>
>  Gabe
>
>
>  Hello,
>
> thank you for your patch, looks good.
>
> However, IMO you can remove hostaddr variable as well, it was used for
> validate IP address.
> I could not find it used anywhere, did you?
>

Removed. It still seemed like it could be a logical check to have to me
which is why I kept it in the first place.
Updated patch attached.


> Martin^2
>
> --
> Martin Basti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150428/4d2a9dfb/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0046-2-Remove-unneeded-ip-address-option-in-ipa-adtrust-ins.patch
Type: text/x-patch
Size: 5462 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150428/4d2a9dfb/attachment.bin>