[Freeipa-devel] [PATCHES 0231-0232] Server Upgrade: support base64 encoded values in update files + remove CSV

[Jan Cholasta]

Dne 27.4.2015 v 16:46 Martin Basti napsal(a):
> On 27/04/15 13:05, Martin Basti wrote:
>> On 23/04/15 13:06, Martin Basti wrote:
>>> On 16/04/15 17:14, Martin Basti wrote:
>>>> https://fedorahosted.org/freeipa/ticket/4984
>>>>
>>>> I had to remove CSV (which is evil) to be able fix this ticket.
>>>>
>>>> Patches attached.
>>>>
>>>>
>>>>
>>> Updated patches attached.
>>>
>>> --
>>> Martin Basti
>>>
>>>
>> Rebased patches attached.
>>
>> --
>> Martin Basti
>>
>>
> rebased patches attached
>
> --
> Martin Basti
>
>
>

ACK on patch 231.

BTW I have found a 7 year old bug caused by CSV while reviewing it: 
<https://fedorahosted.org/freeipa/ticket/5007>.

There is also similar git-only bug in install/updates/10-uniqueness.update:

     default:uniqueness-subtrees: 'cn=accounts,$SUFFIX'
     default:uniqueness-subtrees: 'cn=deleted 
users,cn=accounts,cn=provisioning,$SUFFIX'

but your patch fixes it.

I will review patch 232 later.

Honza

-- 
Jan Cholasta