[Freeipa-devel] [PATCH] Port from python-kerberos library to python-gssapi

[Michael Šimáček]

On 2015-07-27 11:38, Simo Sorce wrote:
> On Sun, 2015-07-26 at 21:51 +0200, Michael Šimáček wrote:
>> It would probably be nicer to do the full cycle, but I'd like to
>> avoid
>> changes in behavior when porting from one library to another. And the
>> code above doesn't actually hold any connection, so it would require
>> more refactoring to make that happen. For now I would follow what the
>> original code was doing. As for the exceptions, I think it would
>> actually be justifiable to use the raw api's init_sec_context,
>> because
>> the high level api would just do the same call + the exception
>> handling
>> magic, which we want to avoid for now. Please let me know what do you
>> think.
>> Attaching updated patch that uses 'unicode' instead of
>> raw.display_name
>> and reverts back to using init_sec_context.
>
> Sorry,
> but we should really not use the raw API here.
> If it means more changes to the code, so be it, please us the high level
> API as recommended by Robbie, we wrote a better API so that people would
> use it, and we want to apply best practices when changing code in IPA.
>

Attaching new revision of the patch that performs the full negotiation 
cycle.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-msimacek-0001-5-Port-from-python-kerberos-to-python-gssapi.patch
Type: text/x-patch
Size: 10572 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150803/ba77b87c/attachment.bin>