[Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

[Gabe Alford]

Hello,

Updated patch attached.

- Time limit is -1 for unlimited. I found this
https://www.redhat.com/archives/freeipa-devel/2011-January/msg00330.html in
reference to keeping the time limit as -1 for unlimited.
Sure enough, testing time limit at 0 did not work for unlimited as well as
appeared to have negative effects on IPA. Also, I believe that
http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
specifies unlimited for time limit as -1. (Please correct me if I am wrong.)

- Size limit is 0 for unlimited per Jan's comment including a conversion
from -1 to 0 if -1 is entered for unlimited size limit.

>            Actually, 0 means unlimited for size limit, see
>            <
http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s>

Thanks,

Gabe

On Tue, Aug 4, 2015 at 3:28 AM, Jan Cholasta <jcholast at redhat.com> wrote:

> Dne 31.7.2015 v 17:08 Gabe Alford napsal(a):
>
>> Updated patch attached.
>>
>> Thanks,
>>
>> Gabe
>>
>> On Thu, Jul 30, 2015 at 7:15 AM, Gabe Alford <redhatrises at gmail.com
>> <mailto:redhatrises at gmail.com>> wrote:
>>
>>     On Thu, Jul 30, 2015 at 1:32 AM, Jan Cholasta <jcholast at redhat.com
>>     <mailto:jcholast at redhat.com>> wrote:
>>
>>         Dne 30.7.2015 v 09:23 Jan Cholasta napsal(a):
>>
>>             Hi,
>>
>>             Dne 29.7.2015 v 17:23 Gabe Alford napsal(a):
>>
>>                 Hello,
>>
>>                 Fix for https://fedorahosted.org/freeipa/ticket/4023
>>
>>
>>             Actually, 0 means unlimited for size limit, see
>>             <
>> http://www.python-ldap.org/doc/html/ldap.html#ldap.LDAPObject.search_ext_s
>> >.
>>
>>
>>         After reading the ticket I think this should be fixed the other
>>         way around: make 0 mean unlimited for both time and size limit
>>         and fix the config plugin and LDAPClient to respect that.
>>
>>
>>     Thanks for the review. Updated patch attached.
>>
>
> We still need to accept -1 in config-mod for backward compatibility - when
> received, it should be converted to 0.
>
> --
> Jan Cholasta
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150806/b76f17ce/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0053-4-Standardize-minvalue-for-ipasearchrecordlimit-and.patch
Type: text/x-patch
Size: 33632 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150806/b76f17ce/attachment.bin>