[Freeipa-devel] [PATCH 0055] raise an exception when user tries to modify a local ID range

Tomas Babej tbabej at redhat.com
Fri Aug 7 14:51:43 UTC 2015



On 08/07/2015 04:22 PM, Martin Babinsky wrote:
> Short term fix for https://fedorahosted.org/freeipa/ticket/4826
> 
> 
> 

Hi,

couple of minor issues:

1.) Please create a separate constant for the WARNING section, now this
segment is copy-pasted at three different places in the plugin.

2.) It would be nice to fix the broken indentation in the help texts for
ipa idrange-add/mod whlie poking at that part of the code.

3.) 'ipa help idranges' does not produce any info, it error message
needs to suggest 'ipa help idrange'

Otherwise looks and works good.

Tomas




More information about the Freeipa-devel mailing list