[Freeipa-devel] [PATCH 0055] raise an exception when user tries to modify a local ID range

[Martin Babinsky]

On 08/07/2015 05:25 PM, Tomas Babej wrote:
>
>
> On 08/07/2015 05:09 PM, Martin Babinsky wrote:
>> On 08/07/2015 04:51 PM, Tomas Babej wrote:
>>>
>>>
>>> On 08/07/2015 04:22 PM, Martin Babinsky wrote:
>>>> Short term fix for https://fedorahosted.org/freeipa/ticket/4826
>>>>
>>>>
>>>>
>>>
>>> Hi,
>>>
>>> couple of minor issues:
>>>
>>> 1.) Please create a separate constant for the WARNING section, now this
>>> segment is copy-pasted at three different places in the plugin.
>>>
>>> 2.) It would be nice to fix the broken indentation in the help texts for
>>> ipa idrange-add/mod whlie poking at that part of the code.
>>>
>> How should these sections be indented (especially the warning parts)?
>>
>
> The section is indented using 4 spaces in "ipa help idrange-mod" (-add).
> I see no point in doing so, Additionally, being a separate block of
> text, it is not visually separated from the options block.
>
>>> 3.) 'ipa help idranges' does not produce any info, it error message
>>> needs to suggest 'ipa help idrange'
>>>
>>> Otherwise looks and works good.
>>>
>>> Tomas
>>>
>>
>>

Attaching updated patch. I have tried to improve the visibility of the 
warning message.

-- 
Martin^3 Babinsky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbabinsk-055.1-idranges-raise-an-error-when-local-IPA-ID-range-is-b.patch
Type: text/x-patch
Size: 3927 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150810/2c20170a/attachment.bin>