[Freeipa-devel] [PATCH] 369 Added CLI param and ACL for vault service operations.

[Jan Cholasta]

On 10.8.2015 21:12, Endi Sukma Dewata wrote:
> On 8/4/2015 10:32 AM, Endi Sukma Dewata wrote:
>>>> Martin, I do not think going on with business as usual is the right
>>>> thing to do here. We know this is going to bite.
>>>> I suggest Endy adds a *new* API if making it backwards compatible is
>>>> not
>>>> possible. The era of bumping whole API version must stop, the sooner
>>>> the
>>>> better.
>>>
>>> My point is that we do not know yet how to do this kind of changes
>>> long term.
>>> So what I did not want to end up are 2 copy&pasted Vault plugins
>>> maintained
>>> forever, differing in just that.
>>>
>>> If you know how to do this without copypasting, I will be fine with
>>> that.
>>
>> We probably can do it like this:
>> * the old plugin continues to provide Vault 1.0 functionality
>> * the new plugin will be a proxy to the old plugin except for the parts
>> that have changed in Vault 1.1.
>>
>> Or the other way around:
>> * the new plugin will provide Vault 1.1 functionality
>> * the old plugin will be a proxy to the new plugin except for the parts
>> that needs to be maintained for Vault 1.0.
>>
>> The first option is probably safer.
>>
>> In any case, IPA 4.2.1 will only provide a single client for Vault 1.1,
>> but two services for Vault 1.0 and 1.1.
>
> A new patch #369-1 is attached. It has been rebased on top of #372 and
> #373 that fix the conflicting parameter while maintaining backward
> compatibility.

I have modified the first version of the patch to maintain backward 
compatibility and not require your patches #372 and #373. Should be much 
easier to review. See attachment.

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-edewata-0369-2-Added-CLI-param-and-ACL-for-vault-service-operations.patch
Type: text/x-patch
Size: 12332 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150811/6616e8c3/attachment.bin>