[Freeipa-devel] [PATCH 0297] ULC: add user-stage command

[Martin Basti]

On 08/18/2015 09:50 AM, thierry bordaz wrote:
> On 08/17/2015 08:33 PM, Martin Basti wrote:
>> Hello,
>>
>> the 'user-stage' command replaces 'stageuser-add --from-delete' command.
>> https://fedorahosted.org/freeipa/ticket/5041
>>
>> Thierry can you check If I don't break everything, it works for me, 
>> but the one never knows.
>>
>> Honza can you please check the framework side? I use 
>> self.api.Object.stageuser.add.* in user command, I'm not sure if this 
>> is right way, but it works.
>>
>> Patch attached. I created it in hurry, I'm expecting NACK :D
>>
>>
>> Just question at the end: should I implement way Active user -> 
>> stageuser? IMHO it would be implemented internally by calling 
>> 'user-del --preserve' inside 'user-stage'.
>>
>>
>>
> Hi Martin,
>
> There is a small failure with VERSION (edewata pushed his patch first 
> ;-) )
>
>     git apply -v /tmp/freeipa-mbasti-0297-Add-user-stage-command.patch
>     Checking patch API.txt...
>     Checking patch VERSION...
>     error: while searching for:
>     #                                                      #
>     ########################################################
>     IPA_API_VERSION_MAJOR=2
>     IPA_API_VERSION_MINOR=148
>     # Last change: ftweedal - add --out option to user-show
>
>     error: patch failed: VERSION:90
>     error: VERSION: patch does not apply
>     Checking patch ipalib/plugins/stageuser.py...
>     Checking patch ipalib/plugins/user.py...
>
>
There is many pending patches that may change VERSION number, I will 
change it to right one before push.

Does code looks good for you?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150818/94860653/attachment.htm>