[Freeipa-devel] [PATCH 0060] user-undel: Fix error messages.

[Martin Basti]

On 08/17/2015 03:39 PM, David Kupka wrote:
> On 14/08/15 17:18, Martin Basti wrote:
>>
>>
>> On 08/13/2015 08:17 AM, David Kupka wrote:
>>> https://fedorahosted.org/freeipa/ticket/5207
>>>
>>> Requires patch freeipa-jcholast-471.1.
>>>
>>>
>>
>> NACK
>>
>> This patch causes internal server error
>>
>> ipa user-del user --preserve
>>
>> [Fri Aug 14 17:16:13.691565 2015] [wsgi:error] [pid 3210] ipa: ERROR:
>> non-public: TypeError: %d format: a number is required, not str
>> [Fri Aug 14 17:16:13.691605 2015] [wsgi:error] [pid 3210] Traceback
>> (most recent call last):
>> [Fri Aug 14 17:16:13.691610 2015] [wsgi:error] [pid 3210]   File
>> "/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 347, in
>> wsgi_execute
>> [Fri Aug 14 17:16:13.691614 2015] [wsgi:error] [pid 3210] result =
>> self.Command[name](*args, **options)
>> [Fri Aug 14 17:16:13.691618 2015] [wsgi:error] [pid 3210]   File
>> "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 457, in
>> __call__
>> [Fri Aug 14 17:16:13.691622 2015] [wsgi:error] [pid 3210]
>> self.validate_output(ret, options['version'])
>> [Fri Aug 14 17:16:13.691626 2015] [wsgi:error] [pid 3210]   File
>> "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 950, in
>> validate_output
>> [Fri Aug 14 17:16:13.691630 2015] [wsgi:error] [pid 3210]
>> o.validate(self, value, version)
>> [Fri Aug 14 17:16:13.691634 2015] [wsgi:error] [pid 3210]   File
>> "/usr/lib/python2.7/site-packages/ipalib/output.py", line 151, in 
>> validate
>> [Fri Aug 14 17:16:13.691638 2015] [wsgi:error] [pid 3210] types[0],
>> type(value), value))
>> [Fri Aug 14 17:16:13.691642 2015] [wsgi:error] [pid 3210] TypeError: %d
>> format: a number is required, not str
>> [Fri Aug 14 17:16:13.692063 2015] [wsgi:error] [pid 3210] ipa: INFO:
>> [jsonserver_session] admin at EXAMPLE.COM: user_del((u'user',),
>> continue=False, preserve=True, version=u'2.148'): TypeError
>> (END)
>>
>>
> Thanks for catching this. Updated patch attached.
>
ACK

Pushed to:
master: 65b8c622070f61ad01a2a1706564911620b022bc
ipa-4-2: 6005dfb5857af5ae46efd2984b06a9a35efb7917