[Freeipa-devel] [PATCH 0060] raise an error when trying to preserve an already preserved user

Martin Babinsky mbabinsk at redhat.com
Thu Aug 20 10:11:28 UTC 2015


On 08/20/2015 11:41 AM, thierry bordaz wrote:
> On 08/19/2015 06:28 PM, Martin Babinsky wrote:
>> On 08/19/2015 02:54 PM, Martin Babinsky wrote:
>>> this patch prevents https://fedorahosted.org/freeipa/ticket/5234 from
>>> happening.
>>>
>>>
>>>
>> Actually, we (myself, mbasti, jcholast) found out that `user-del
>> --preserve` could use some more usability improvements.
>>
>> This quick patch should fix both
>> https://fedorahosted.org/freeipa/ticket/5234 and
>> https://fedorahosted.org/freeipa/ticket/5236 and make user
>> preservation operate on multiple arguments in a same way as plain
>> deletion.
>>
>>
>>
>
> Hi Martin,
>
> The tests are ok and the fix looks good to me.
>
> ACK
>
> thanks
> thierry

That's nice, but I have found some small nitpicks and will send an 
updated version.

So self-NACK.

-- 
Martin^3 Babinsky




More information about the Freeipa-devel mailing list