[Freeipa-devel] [PATCHES] changes in preparation of replica promotion work

Simo Sorce simo at redhat.com
Tue Aug 25 18:43:59 UTC 2015


On Wed, 2015-08-05 at 11:24 -0400, Simo Sorce wrote:
> On Wed, 2015-08-05 at 08:20 +0200, Jan Cholasta wrote:
> > Hi,
> > 
> > Dne 31.7.2015 v 12:46 Simo Sorce napsal(a):
> > > I've been carrying these patches in my tree for a while, I think it is
> > > time to put them in master as they stand on their own.
> > >
> > > Simo.
> > 
> > Patch 530: ACK
> > 
> > Patch 531: ACK
> > 
> > Patch 532:
> > 
> > The methods should be static methods:
> > 
> >      @staticmethod
> >      def setOption(name, value):
> >      ...
> 
> Care to explain why ?
> @staticmethod is not used anywhere else in that file.

Rebased patches on master, made requested change +1 more patch.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-simo-530-2-Remove-custom-utility-function-from-krbinstance.patch
Type: text/x-patch
Size: 2293 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150825/07cb2332/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-simo-531-2-Move-sasl-mappings-creation-to-dsinstance.patch
Type: text/x-patch
Size: 6981 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150825/07cb2332/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-simo-532-2-Simplify-adding-options-in-ipachangeconf.patch
Type: text/x-patch
Size: 1318 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150825/07cb2332/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-simo-533-2-Insure-the-admin_conn-is-disconnected-on-stop.patch
Type: text/x-patch
Size: 1226 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150825/07cb2332/attachment-0003.bin>


More information about the Freeipa-devel mailing list