[Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin

[Filip Škola]

Hi,

sending corrected version.

F.

On Thu, 12 Nov 2015 14:03:19 +0100
Milan Kubík <mkubik at redhat.com> wrote:

> On 11/10/2015 12:13 PM, Filip Škola wrote:
> > Hi,
> >
> > fixed.
> >
> > F.
> >
> > On Tue, 10 Nov 2015 10:52:45 +0100
> > Milan Kubík <mkubik at redhat.com> wrote:
> >
> >> On 11/09/2015 04:35 PM, Filip Škola wrote:
> >>> Another patch was applied in the meantime.
> >>>
> >>> Attaching an updated version.
> >>>
> >>> F.
> >>>
> >>> On Mon, 9 Nov 2015 13:35:02 +0100
> >>> Milan Kubík <mkubik at redhat.com> wrote:
> >>>
> >>>> On 11/06/2015 11:32 AM, Filip Škola wrote:
> >>>> Hi,
> >>>> the patch doesn't apply.
> >>>>
> >> Please fix this.
> >>
> >>       ipatests/test_xmlrpc/test_user_plugin.py:1419:
> >> [E0602(undefined-variable),
> >> TestDeniedBindWithExpiredPrincipal.teardown_class] Undefined
> >> variable 'user1')
> >>
> >> Also, use the version numbers for your changed patches.
> >>
> >
> >
> Thanks for the patch. Several issues:
> 
> 1. Use dict.items instead of dict.iteritems, for python3 compatibility
> 
> 2. What is the purpose of TestPrepare class? The 'purge' methods do
> not call any ipa commands.
> Tracker.make_fixture should be used to make the Tracked resources
> clean themselves up when they're out of scope.
> 
> 3. Why reference the resources by hardcoded name if they have a
> fixture representation?
> 
> 4. Rewrite {create,delete}_test_group to a fixture. You may want to
> use different scope (or not).
> 
> 5. In `def atest_rename_to_invalid_login(self, user):` - use 
> pytest.skipif decorator and provide a reason if you must,
> do not obfuscate method name in order not to run it.
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-fskola-0001-3-Refactor-test_user_plugin.patch
Type: text/x-patch
Size: 98251 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151203/f528e1bf/attachment.bin>