[Freeipa-devel] [PATCH 0058, 0064] dns: do not add (forward)zone if it is already resolvable.

Petr Spacek pspacek at redhat.com
Tue Dec 8 07:56:32 UTC 2015


On 7.12.2015 14:41, David Kupka wrote:
> +def is_host_resolvable(fqdn):
> +    if not isinstance(fqdn, DNSName):
> +        fqdn = DNSName(fqdn)
> +    for rdtype in (rdatatype.A, rdatatype.AAAA):
> +        try:
> +            resolver.query(fqdn.make_absolute(), rdtype)
> +        except DNSException:
> +            continue
> +        else:
> +            return True
> +
> +    return False
>  

NACK, you are re-introducing duplicate function which was removed in
498471e4aed1367b72cd74d15811d0584a6ee268.

Please amend the patch ASAP to use new verify_host_resolvable() function so I
can test it and get it into 4.3.

-- 
Petr^2 Spacek




More information about the Freeipa-devel mailing list