[Freeipa-devel] [PATCHES 531-532] server install: redirect ipa-client-install output to standard output

Tomas Babej tbabej at redhat.com
Mon Dec 14 13:47:22 UTC 2015



On 12/14/2015 02:41 PM, Jan Cholasta wrote:
> On 14.12.2015 14:20, Tomas Babej wrote:
>>
>>
>> On 12/14/2015 12:57 PM, Jan Cholasta wrote:
>>> On 14.12.2015 12:54, Tomas Babej wrote:
>>>>
>>>>
>>>> On 12/14/2015 12:52 PM, Jan Cholasta wrote:
>>>>> Hi,
>>>>>
>>>>> the attached patches fix
>>>>> <https://fedorahosted.org/freeipa/ticket/5527>.
>>>>>
>>>>> Honza
>>>>>
>>>>>
>>>>>
>>>>
>>>> Shouldn't skip_output be also marked as incompatible with
>>>> redirect_output?
>>>
>>> Yes, it should.
>>>
>>
>> Otherwise the patch works fine, so conditional ACK here given that the
>> additional sanity check is implemented.
> 
> Updated patches attched.
> 

Thanks, I just removed the empty space in the 'print ()' call before
pushing.

ACK, Pushed to master: c856401478ce2f4fdd9cd7192afd18704f78e2e6

Tomas




More information about the Freeipa-devel mailing list