[Freeipa-devel] [PATCH 0365] Remove unused KRA code from ipa-server-install

[Martin Basti]

On 15.12.2015 16:43, David Kupka wrote:
> On 15/12/15 16:20, Martin Kosek wrote:
>> On 12/15/2015 07:42 AM, Jan Cholasta wrote:
>>> On 14.12.2015 16:54, Alexander Bokovoy wrote:
>>>> On Mon, 14 Dec 2015, David Kupka wrote:
>> ...
>>> We can always have both. With the new installer framework it is 
>>> trivial to fold
>>> installers like this without code duplication. It is still work in 
>>> progress
>>> though, so I would prefer not to add --setup-kra to 
>>> ipa-server-install now (if
>>> ever).
>>
>> +1, I would also rather not make ipa-server-install too monolithic. 
>> Even from
>> testing POV, I think doing KRA fixes in one installer is much more 
>> easier than
>> doing it also in replica or server installers (although Jan's patches 
>> help
>> here, that's true).
>>
>
> If you look on the patch Martin send, you will see that there is 
> nothing monolithic in installing KRA in ipa-server-install.
> In fact, it calls kra.check_install() and kra.install(), the very same 
> functions that are called from ipa-kra-install.
>
> But it seems that majority of us is decided to remove the ability to 
> install KRA from ipa-server-install and since I've tested the patch 
> and didn't find any issues we can push it, ACK.
>
Pushed to master: e622da3e1a25c05b77fed538634c284e68e2397f