[Freeipa-devel] [PATCH 0077] ipa-dns-install: Do not check for zone overlap when DNS, installed.

[Martin Basti]

On 22.12.2015 14:33, Petr Spacek wrote:
> On 22.12.2015 13:14, David Kupka wrote:
>> On 18/12/15 15:39, Petr Vobornik wrote:
>>> On 12/18/2015 12:04 PM, Petr Vobornik wrote:
>>>> On 12/18/2015 11:26 AM, David Kupka wrote:
>>>>> Standalone DNS installer always performed overlap check effectively
>>>>> preventing installation on replica when other DNS instance was already
>>>>> installed in topology.
>>>>>
>>>>>
>>>> I don't like the position of api argument in the install_check. It is
>>>> not consistent with install_check in KRA plus it's between two related
>>>> options: standalone and replica.
>>>>
>>>> Is there a reason behind it which I don't see?
>>> NACK, the API call is incorrect.
>>>
>>> It should be api.Command['dns_is_enabled']()['result'] or
>>> api.Command.dns_is_enabled()['result']
>>>
>>>
>>> ipa-dns-install --forwarder=$DNS_FORWARDER
>>>
>>> The log file for this installation can be found in
>>> /var/log/ipaserver-install.log
>>> Unexpected error - see /var/log/ipaserver-install.log for details:
>>> TypeError: __call__() takes exactly 1 argument (2 given)
>>>
>>>
>>> log file:
>>>
>>> 2015-12-18T14:33:30Z DEBUG   File
>>> "/usr/lib/python2.7/site-packages/ipaserver/install/installutils.py",
>>> line 736, in run_script
>>>       return_value = main_function()
>>>
>>>     File "/sbin/ipa-dns-install", line 137, in main
>>>       dns_installer.install_check(True, api, False, options,
>>> hostname=api.env.host)
>>>
>>>     File "/usr/lib/python2.7/site-packages/ipaserver/install/dns.py",
>>> line 113, in install_check
>>>       already_enabled = api.Command('dns_is_enabled')['result']
>>>
>>> 2015-12-18T14:33:30Z DEBUG The ipa-dns-install command failed,
>>> exception: TypeError: __call__() takes exactly 1 argument (2 given)
>>>
>> Thanks for catch. Sometimes I mess up with patch files. Fixed patch attached.
> ACK, works for me.
>
Pushed to master: 8ad39a974fd4e1cc6fd2a09b1d9d0c8724983b15
Pushed to ipa-4-3: bfad829586f40e20ada21ea932377089901aaf61