[Freeipa-devel] [PATCH 0041] permission-add does not prompt for ipapermright option in interactive mode

[Martin Basti]

On 11/02/15 17:28, Gabe Alford wrote:
> Oops. My mistake. Corrected patch attached.
>
> On Wed, Feb 11, 2015 at 8:59 AM, Martin Basti <mbasti at redhat.com 
> <mailto:mbasti at redhat.com>> wrote:
>
>     Sorry, alwaysask didnt work.
>     It was asking for rights during permission-mod.
>
>     I replaced alwaysask with flag "ask_create".
>     Sorry for late catch.
>
>     Updated patch attached.
>
>     PS: your name+email is missing in commit message, is it on
>     purpose? And time wasn't correct in previous patch.
>
>
>
>     On 11/02/15 15:06, Gabe Alford wrote:
>>     Good point. I personally was not aware of all that the API can
>>     do. Thanks Martin^2! Updated patch attached.
>>
>>     On Tue, Feb 10, 2015 at 11:42 AM, Martin Basti <mbasti at redhat.com
>>     <mailto:mbasti at redhat.com>> wrote:
>>
>>         On 29/01/15 17:10, Gabe Alford wrote:
>>>         Hello,
>>>
>>>         Fix for https://fedorahosted.org/freeipa/ticket/4872
>>>
>>>         Thanks,
>>>
>>>         Gabe
>>>
>>>
>>>         _______________________________________________
>>>         Freeipa-devel mailing list
>>>         Freeipa-devel at redhat.com  <mailto:Freeipa-devel at redhat.com>
>>>         https://www.redhat.com/mailman/listinfo/freeipa-devel
>>         Thank you for your patch.
>>
>>         IMO, would be better to use flag, alwaysask for ipapermright,
>>         instead of creating new callback:
>>
>>                  StrEnum(
>>                      'ipapermright*',
>>                      cli_name='right',
>>         deprecated_cli_aliases={'permissions'},
>>                      label=_('Granted rights'),
>>                      doc=_('Rights to grant '
>>                            '(read, search, compare, write, add,
>>         delete, all)'),
>>                      values=(u'read', u'search', u'compare',
>>                              u'write', u'add', u'delete', u'all'),
>>         +            alwaysask=True,
>>                  ),
>>
>>         This change requires to generate new API.txt
>>
>>         please run ./makeapi  and increment API version in VERSION file.
>>
>>         Thank you in advance :-)
>>
>>         Martin^2
>>
>>         -- 
>>         Martin Basti
>>
>>
>
>
>     -- 
>     Martin Basti
>
>
Thank you

ACK

-- 
Martin Basti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150212/8c089abe/attachment.htm>