[Freeipa-devel] [PATCH 0012] migrate-ds: exit with error message if no users/groups to migrate are found

[David Kupka]

On 01/30/2015 11:00 AM, Martin Babinsky wrote:
> On 01/30/2015 10:54 AM, Martin Babinsky wrote:
>> Attached patch fixes https://fedorahosted.org/freeipa/ticket/4864.
>>
>>
>>
>> _______________________________________________
>> Freeipa-devel mailing list
>> Freeipa-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>
>
> Got the ticket number wrong. Should be
> https://fedorahosted.org/freeipa/ticket/4846
>
> Attaching patch with fixed description.
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
>

Hi,
thanks for the patch. It works as expected but you've done two things in 
one patch:
1. Added check for empty migration.
2. Removed unused parameter of function.

Each of them would be enough to fix the issue. Raising error seems to be 
better solution.
If you think that unused parameters (yes, there is not only one :-) 
should be removed please do it in separate patch.

-- 
David Kupka