[Freeipa-devel] [PATCH 0012] migrate-ds: exit with error message if no users/groups to migrate are found

[Martin Kosek]

On 02/16/2015 02:50 PM, David Kupka wrote:
> On 02/13/2015 07:13 PM, Martin Babinsky wrote:
>> On 02/13/2015 12:10 PM, David Kupka wrote:
>>> On 01/30/2015 11:00 AM, Martin Babinsky wrote:
>>>> On 01/30/2015 10:54 AM, Martin Babinsky wrote:
>>>>> Attached patch fixes https://fedorahosted.org/freeipa/ticket/4864.
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Freeipa-devel mailing list
>>>>> Freeipa-devel at redhat.com
>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>
>>>>
>>>> Got the ticket number wrong. Should be
>>>> https://fedorahosted.org/freeipa/ticket/4846
>>>>
>>>> Attaching patch with fixed description.
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Freeipa-devel mailing list
>>>> Freeipa-devel at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>
>>>
>>> Hi,
>>> thanks for the patch. It works as expected but you've done two things in
>>> one patch:
>>> 1. Added check for empty migration.
>>> 2. Removed unused parameter of function.
>>>
>>> Each of them would be enough to fix the issue. Raising error seems to be
>>> better solution.
>>> If you think that unused parameters (yes, there is not only one :-)
>>> should be removed please do it in separate patch.
>>>
>> Very well,
>>
>> I am attaching patch which features only the check for empty user/group
>> containers during migration.
>>
>> I will also add example steps to reproduce
>> https://fedorahosted.org/freeipa/ticket/4846 since it can be a bit tricky:
>>
>> 1. Setup 389 directory server on one machine using setup-ds.pl script.
>>
>> 2. Delete all user and group entries from LDAP tree.
>>
>> 3. Setup an IPA master on another machine.
>>
>> 4. Enable migration of users/groups from 389DS to IPA master:
>>     ipa config-mod --enable-migration=True
>>
>> 5. Force-migrate users/group from 389DS:
>>     ipa migrate-ds ${389DS_LDAP_URI} --continue --with-compat
>>
>> 6. See /var/log/httpd/error_log for the resulting traceback.
>>
> 
> Thanks, ACK.
> 

Pushed to:
master: 06376a48b24949a1144d037af9fbed89d0455d79
ipa-4-1: f7e6102ebfd6e2a87bd584fc2fbbcb9945ac7753

Martin