[Freeipa-devel] [PATCH 0002] Changing the token owner also changes its manager

[Petr Vobornik]

On 01/14/2015 08:02 PM, Nathaniel McCallum wrote:
> On Wed, 2015-01-14 at 17:49 +0100, Martin Babinsky wrote:
>> On 01/14/2015 05:23 PM, Nathaniel McCallum wrote:
>>> On Wed, 2015-01-14 at 16:49 +0100, Martin Babinsky wrote:
>>>> Changing the owner of a token also implicitly sets the new owner as its
>>>> manager if following conditions are met:
>>>>
>>>> 1.) The original token owner was also its manager
>>>>
>>>> 2.) The new manager is not set explicitly via CLI interface.
>>>>
>>>> If the owner is unset and the above conditions are met, then the manager
>>>> of the token will also be unset.
>>>>
>>>> https://fedorahosted.org/freeipa/ticket/4681
>>>
>>> Nitpicks:
>>> 1. The commit message summary line should not have a '.'
>>> 2. The commit message is not properly wrapped.
>>> 3. The newline before _normalize_owner() is undesirable.
>>> 4. Shouldn't prev_managed_by be prev_managedby?
>>>
>>> The main body of the change looks good to me.
>>>
>>> Nathaniel
>>>
>>
>> Attaching updated patch.
>
> ACK
>

Pushed to:
master: b95f4330c9433683f61c46f9605fd1d24bb8b998
ipa-4-1: c985de1ee6429c49e6273a037478212e7ee301c8
-- 
Petr Vobornik