[Freeipa-devel] [PATCH] 0036 Abort full backup restoration on not matching host.

[Martin Kosek]

On 01/12/2015 01:37 PM, David Kupka wrote:
> On 01/12/2015 01:14 PM, Jan Cholasta wrote:
>> Dne 12.1.2015 v 13:08 Martin Kosek napsal(a):
>>> On 01/12/2015 12:53 PM, David Kupka wrote:
>>>> https://fedorahosted.org/freeipa/ticket/4823
>>>
>>> Looking at this patch, are data-only backups supposed to work properly
>>> then?
>>> Wouldn't for example Directory Server fail to start when cn=config
>>> contain some
>>> hostname-bound values?
>>>
>>> Just checking...
>>>
>>
>> IMO the error should be raised in both data-only and full restore, if in
>> unattended mode or the user wishes not to continue.
>>
> Description of the problem in ticket states: "I tried to run ipa-restore (full
> kind) on replica from full backup taken on master and was expecting an error
> message that restore can not proceed and only data restore possible."

That report does not discuss data-only backups at all. That does not mean they
do not need to be taken care of.

> I created the patch based on this request. Is it wrong and should ipa-restore
> fail every time when hostnames does not match? Does it make sense to allow user
> to force the restoration in this case? Thanks for clarification.

I think the behavior that Jan proposed is fine, i.e. warn and ask in attended
mode, fail in unattended mode.

Martin