[Freeipa-devel] [PATCH 0022] Fix default value type for wait_for_dns optio

[Martin Kosek]

On 01/13/2015 11:11 AM, Petr Spacek wrote:
> On 13.1.2015 10:57, Martin Kosek wrote:
>> On 01/13/2015 10:16 AM, Petr Spacek wrote:
>>> Hello,
>>>
>>> Fix default value type for wait_for_dns option
>>>
>>> wait_for_dns value should be an integer so default value was changed from
>>> False to 0.
>>>
>>
>> Thanks. I stumbled on this value this morning, when setting it to True did not
>> work.
>>
>> IMO, it would make sense to even rename the option to something that does not
>> indicate boolean semantics, like "dns_wait_retry_attempts" or similar. But it
>> may be too disruptive as at least our CI scripts would have to be updated.
>>
>> Up to you.
> 
> Well, open a ticket for option rename :-)

I am not bothered by the name that much :-)

> Anyway, this change can be pushed as-is (after review) even if we decide to
> rename it later.

Ok, works for me.

ACK. Pushed to master: 2ff8ced5175f8def1b07786d20b64c1450be0567

Martin