[Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases

[Martin Basti]

On 13/01/15 10:04, Martin Kosek wrote:
> On 01/12/2015 06:43 PM, Martin Basti wrote:
>> On 05/01/15 16:18, Martin Basti wrote:
>>> On 17/12/14 15:15, Martin Basti wrote:
>>>> On 16/12/14 17:14, Martin Basti wrote:
>>>>> On 15/12/14 20:15, Martin Basti wrote:
>>>>>> On 15/12/14 19:18, Martin Basti wrote:
>>>>>>> https://fedorahosted.org/freeipa/ticket/4750
>>>>>>>
>>>>>>> Patches need rebase and minor pytest modification to apply on master, I
>>>>>>> will do that after review.
>>>>>>>
>>>>>>> Patches for ipa-4-1 attached.
>>>>>>>
>>>>>>>
>>>>>> I forgot to fix copy paste error.
>>>>>>
>>>>>> Updated patches attached
>>>>>>
>>>>> Removed unneeded  nsrecord validation in 2 tests
>>>>>
>>>>> updated patches attached
>>>>>
>>>> Added:
>>>>
>>>> * find forward zone with --forward-policy=none (no fwzone exists)
>>>> * find forward zone with --forward-policy=only (no fwzone exists)
>>>> * find forward zone with --forward-policy=first (no fwzone exists)
>>>> * enable enabled zone
>>>> * disable disabled zone
>>>>
>>>> Patches attached.
>>>>
>>>>
>>> Hi Scott, could you ack or nack the patchset, other test tickets are waiting,
>>> and we want to avoid huge rebases/merging
>>>
>>  From QA point of view, tests are OK. Can somebody do code review please?
> Code looks OK, runs cleanly (except that I thought that wait_for_dns is boolean
> value and not an integer :-/)
>
> So ACK from me. After you prepare a version for master branch, we can push them.
>
> Martin
Rebased patches attached



-- 
Martin Basti

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-master-mbasti-0176.4-New-test-cases-for-Forward_zones.patch
Type: text/x-patch
Size: 39230 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150113/1679c342/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-master-mbasti-0175.4-DNS-tests-separate-current-forward-zone-tests.patch
Type: text/x-patch
Size: 32158 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150113/1679c342/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-4.1-mbasti-0176.4-New-test-cases-for-Forward_zones.patch
Type: text/x-patch
Size: 39232 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150113/1679c342/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-4.1-mbasti-0175.4-DNS-tests-separate-current-forward-zone-tests.patch
Type: text/x-patch
Size: 32152 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150113/1679c342/attachment-0003.bin>