[Freeipa-devel] [PATCH] 387 Fix validation of ipa-restore options

Martin Kosek mkosek at redhat.com
Wed Jan 14 12:10:09 UTC 2015


On 01/14/2015 12:35 PM, Petr Viktorin wrote:
> On 01/14/2015 09:14 AM, Martin Kosek wrote:
>> On 01/13/2015 06:02 PM, Jan Cholasta wrote:
> 
>>> Rebased again, patch attached.
>>
>> Given that Petr is not there today, I finished the review for him. I did not
>> find any other issues, all issues except (2) are fixed.
>>
>> ACK. Pushed to master (rebased) and ipa-4-1.
> 
> This broke master.
> 
> ************* Module ipaserver.install.ipa_restore
> ipaserver/install/ipa_restore.py:175: [E0602(undefined-variable),
> Restore.validate_options] Undefined variable 'BACKUP_DIR')
> ipaserver/install/ipa_restore.py:210: [E0602(undefined-variable), Restore.run]
> Undefined variable 'BACKUP_DIR')
> 

Grr... Sorry for the hickup, I fixed it with the attached patch and pushed it
to master as a one liner.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkosek-490-fix-ipa_backup_dir-path-name.patch
Type: text/x-patch
Size: 1401 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150114/c2388bc0/attachment.bin>


More information about the Freeipa-devel mailing list