[Freeipa-devel] [PATCH 0039] Add test case for unsupported arg for ipa-advise

[Tomas Babej]

On 01/14/2015 02:55 PM, Gabe Alford wrote:
> Hello,
>
>        In looking into https://fedorahosted.org/freeipa/ticket/4029 I
> am wondering if there should be separate ipa-advise test, Yes/No?
> Could be handy in the future to test more ipa-advise output? Or should
> this test be added to the test_legacy_clients.py?
>
> Thanks,
>
> Gabe  
>
> On Tue, Dec 2, 2014 at 9:21 PM, Gabe Alford <redhatrises at gmail.com
> <mailto:redhatrises at gmail.com>> wrote:
>
>     Hello,
>
>     I was going to try my hand at attempting a patch for ipa-tests.
>     However in wanting to test my patch, I am not sure how to run
>     ipa-tests to check if it works or not. Documentation is not really
>     clear on what needs to be done to start a test and run a test.
>     This is for https://fedorahosted.org/freeipa/ticket/4029
>
>     I have attached the patch that I have yet to really test with
>     ipa-test. Any help on how to test the patch running ipa-tests
>     would be great. Of course, if one of the reviewers looks at the
>     patch and looks good, then I would be happy with that as well.
>
>     Thanks,
>
>     Gabe
>
>
>
>
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Hello,

TL;DR: feel free to create a separate ipa-advise test file. Test
requested in this ticket really does not belong to the legacy clients
feature test.

As for the any new tests that might come: I think tests for ipa-advise
that are specific to that particular feature should be tested with that
feature, more so, if they contain parts that are supposed to work
copy-pasted. If a tests, however, tests a general behaviour of
ipa-advise, it should live in the ipa-advise namespace, hence separate
test file.

HTH,

-- 
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150114/6cc5f9b4/attachment.htm>