[Freeipa-devel] [PATCH 0184] Always return absolute idnsname in dnszone commands

[Jan Cholasta]

Hi,

Dne 15.1.2015 v 13:27 Martin Basti napsal(a):
> On 15/01/15 13:17, Martin Basti wrote:
>> https://fedorahosted.org/freeipa/ticket/4722
>>
>> Patch attached.
>>
> Fast fix.
>
> Updated patch attached.

1) Forward zone commands are not fixed.

2) It seems that the primary key returned by -mod, -del and -show 
(.result.value) is made absolute somewhere else in the code. Would it be 
possible to do it in one place?

3) Attribute values returned from LDAP are never None, so the if should 
be "if 'idnsname' in entry_attrs:".

4) If idnsname always has only single value, use 
"entry_attrs.single_value['idnsname'] = 
entry_attrs.single_value['idnsname'].make_absolute()"

Honza

-- 
Jan Cholasta