[Freeipa-devel] [PATCH] 390 Do not crash on unknown services in installutils.stopped_service

[Martin Kosek]

On 01/20/2015 12:19 PM, David Kupka wrote:
> On 01/20/2015 12:07 PM, Martin Kosek wrote:
>> On 01/20/2015 10:49 AM, Jan Cholasta wrote:
>>> Dne 13.1.2015 v 18:55 Jan Cholasta napsal(a):
>>>> Dne 13.1.2015 v 18:46 David Kupka napsal(a):
>>>>> On 01/13/2015 05:55 PM, Jan Cholasta wrote:
>>>>>> Dne 13.1.2015 v 12:12 Jan Cholasta napsal(a):
>>>>>>> Hi,
>>>>>>>
>>>>>>> the attached patch fixes
>>>>>>> <https://fedorahosted.org/freeipa/ticket/4835>.
>>>>>>>
>>>>>>> Honza
>>>>>>
>>>>>> Modified the fix to create only one service object in stopped_service.
>>>>>>
>>>>>> Updated patch attached.
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Freeipa-devel mailing list
>>>>>> Freeipa-devel at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>>>>
>>>>> Hi!
>>>>> Thanks for the patch. Works for me, ACK.
>>>>>
>>>>
>>>> Thanks, pushed to:
>>>> master: 5bf1c9a6f7d734c296c8eb987cfc4f7e2a345130
>>>> ipa-4-1: 065e2bbc9f2260d8c60c55f92a386513727576da
>>>>
>>>
>>> Posting additional patch 393 which is necessary to properly fix this.
>>>
>>> David, could you take a look please?
>>
>> Just looking at this patch, I am thinking it would be great to have
>> @contextmanager also for "started_service" (we already have stopped_service)
>> and use it (not required for this patch though).
> 
> It would be handy. And there is an other solution for this specific case.
> Certmonger could be started with incoming DBus message. This will improve the
> usability not only with freeipa but also with command-line tools like getcert.
> I've filled a ticket for certmonger: https://fedorahosted.org/certmonger/ticket/38

Right.

But this needs more testing and care. Currently, we need to stabilize and fix a
bug in FreeIPA that is also requested from downstream platform. Jan's
patch/approach will be good for now.

Martin