[Freeipa-devel] [PATCH] Use curl instead of wget

Alexander Bokovoy abokovoy at redhat.com
Thu Jan 22 05:23:57 UTC 2015


On Wed, 21 Jan 2015, Colin Walters wrote:
>[Note I didn't test this patch]
>
>Curl has a shared library, and so ends up being used by more components
>of the OS.  It should be preferred over wget.
>
>The motivation for this patch is for Project Atomic hosts; we want to
>include ipa-client, but trim down its dependencies.
>
>If wget isn't installed on the host, it doesn't need to be updated for
>security errata.
>---
> freeipa.spec.in                            |  4 ++--
> ipa-client/ipa-install/ipa-client-install  |  2 +-
> ipaplatform/base/paths.py                  |  1 -
> ipaplatform/redhat/services.py             |  8 ++++----
> ipaserver/advise/plugins/legacy_clients.py | 16 ++++++++--------
> 5 files changed, 15 insertions(+), 16 deletions(-)
>
In general, I'm not against trimming this dependency. However, please
follow existing pattern by defining paths.BIN_CURL and using it instead
of paths.BIN_WGET. FreeIPA client runs on Debian GNU/Linux-based
platforms as well and we need to keep the abstraction.

-- 
/ Alexander Bokovoy




More information about the Freeipa-devel mailing list