[Freeipa-devel] [PATCHES 0187, 0188] DNSSEC ipa-dnskeysyncd fixes

[Jan Cholasta]

Hi,

Dne 21.1.2015 v 13:39 Martin Basti napsal(a):
> Patch 188 catch ldap exceptions to prevent false positive abrt reports
>
> Patch 187 fixes issues with removing root zone
>
> Patches attached.

Patch 187:

Is there a reason only SERVER_DOWN and CONNECT_ERROR are handled, 
instead of any LDAPError?

Patch 188:

IMO it would be slightly better to do it like this:

-        name = name.relativize(dns.name.root)
+        if name != dns.name.root:
+            name = name.relativize(dns.name.root)

Honza

-- 
Jan Cholasta